netdev - Re: [net-next V2 03/12] net/mlx5e: Move mlx5e_tx_wqe_inline_mode to en

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c8af3b1ef5915253ad1c2b720b0e54f942d4d1c9.camel@nvidia.com>
Date:   Fri, 11 Sep 2020 17:25:06 +0000
From:   Saeed Mahameed <saeedm@...dia.com>
To:     "davem@...emloft.net" <davem@...emloft.net>
CC:     "kuba@...nel.org" <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "tariqt@...lanox.com" <tariqt@...lanox.com>,
        "maximmi@...lanox.com" <maximmi@...lanox.com>
Subject: Re: [net-next V2 03/12] net/mlx5e: Move mlx5e_tx_wqe_inline_mode to
 en_tx.c

On Wed, 2020-09-09 at 14:34 -0700, David Miller wrote:
> From: Saeed Mahameed <saeedm@...dia.com>
> Date: Wed, 9 Sep 2020 19:22:02 +0000
> 
> > Maxim really tried here to avoid this without huge performance
> > degradation (~6.4% reduce in packet rate), due to the refactoring
> > patches gcc yields non optimal code, as we explained in the commit
> > messages and cover-letter
> > 
> > Our other option is making the code very ugly with no code reuse in
> > the
> > tx path, so we would really appreciate if you could relax the no-
> > inline 
> > guideline for this series.
> 
> Submit a compiler bug report.
> 
> I'm standing firm on our policy.  If you don't follow it, there is
> zero
> incentive to get the compiler fixed, which cures the problem in one
> place and for everyone rather than just your special case.
> 
Ack, 

Maxim will be testing several versions of GCC to compare and understand
the behavior better and will resubmit a version with no manual inline
hints later, for now i would like to put this on-hold and send the next
pull request.

Thanks,
Saeed.