lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 11 Sep 2020 14:42:07 -0700 From: Jesse Brandeburg <jesse.brandeburg@...el.com> To: Edward Cree <ecree@...arflare.com> Cc: <netdev@...r.kernel.org>, <intel-wired-lan@...ts.osuosl.org> Subject: Re: [RFC PATCH net-next v1 11/11] drivers/net/ethernet: clean up mis-targeted comments Edward Cree wrote: > On 11/09/2020 02:23, Jesse Brandeburg wrote: > > + * @MC_CMD_PTP_IN_TRANSMIT_LENMAX: hack to get W=1 to compile > I think I'd rather have a bogus warning than bogus kerneldocto suppress it; > please drop this line (and encourage toolchain folks to figure out how to > get kerneldoc to ignore macros it can't understand). > Apart from that, the sfc and sfc/falcon parts LGTM. > > -ed Thanks Ed, I think I might just remove the /** on that function then (removing it from kdoc processing), would that be acceptable in the meantime? Of course I'd remove the line I added as well. - Jesse
Powered by blists - more mailing lists