netdev - Re: [PATCH net-next] bridge: mcast: Fix incomplete MDB dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200911.145025.2133088801719324101.davem@davemloft.net>
Date:   Fri, 11 Sep 2020 14:50:25 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     idosch@...sch.org
Cc:     netdev@...r.kernel.org, bridge@...ts.linux-foundation.org,
        kuba@...nel.org, roopa@...dia.com, nikolay@...dia.com,
        jiri@...dia.com, mlxsw@...dia.com, idosch@...dia.com
Subject: Re: [PATCH net-next] bridge: mcast: Fix incomplete MDB dump

From: Ido Schimmel <idosch@...sch.org>
Date: Fri, 11 Sep 2020 16:24:47 +0300

> From: Ido Schimmel <idosch@...dia.com>
> 
> Each MDB entry is encoded in a nested netlink attribute called
> 'MDBA_MDB_ENTRY'. In turn, this attribute contains another nested
> attributed called 'MDBA_MDB_ENTRY_INFO', which encodes a single port
> group entry within the MDB entry.
> 
> The cited commit added the ability to restart a dump from a specific
> port group entry. However, on failure to add a port group entry to the
> dump the entire MDB entry (stored in 'nest2') is removed, resulting in
> missing port group entries.
> 
> Fix this by finalizing the MDB entry with the partial list of already
> encoded port group entries.
> 
> Fixes: 5205e919c9f0 ("net: bridge: mcast: add support for src list and filter mode dumping")
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> Acked-by: Nikolay Aleksandrov <nikolay@...dia.com>
> Reviewed-by: Jiri Pirko <jiri@...dia.com>

Applied, thank you.