netdev - Re: [PATCH bpf-next v3 1/9] bpf: change logging calls from verbose() to bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87d02sbplq.fsf@toke.dk>
Date:   Fri, 11 Sep 2020 12:00:01 +0200
From:   Toke Høiland-Jørgensen <toke@...hat.com>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        Andrii Nakryiko <andriin@...com>,
        John Fastabend <john.fastabend@...il.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Eelco Chaudron <echaudro@...hat.com>,
        KP Singh <kpsingh@...omium.org>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH bpf-next v3 1/9] bpf: change logging calls from
 verbose() to bpf_log() and use log pointer

Andrii Nakryiko <andrii.nakryiko@...il.com> writes:

> On Thu, Sep 10, 2020 at 6:13 AM Toke Høiland-Jørgensen <toke@...hat.com> wrote:
>>
>> From: Toke Høiland-Jørgensen <toke@...hat.com>
>>
>> In preparation for moving code around, change a bunch of references to
>> env->log (and the verbose() logging helper) to use bpf_log() and a direct
>> pointer to struct bpf_verifier_log. While we're touching the function
>> signature, mark the 'prog' argument to bpf_check_type_match() as const.
>>
>> Also enhance the bpf_verifier_log_needed() check to handle NULL pointers
>> for the log struct so we can re-use the code with logging disabled.
>>
>> Signed-off-by: Toke Høiland-Jørgensen <toke@...hat.com>
>> ---
>
> Only 4 out of 9 emails arrived, can you please resubmit your entire
> patch set again?

Sure, done :)

-Toke