netdev - Re: [PATCH net-next] net: hns: use IRQ_NOAUTOEN to avoid irq is enabled due to request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 11 Sep 2020 17:41:05 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     song.bao.hua@...ilicon.com
Cc:     kuba@...nel.org, netdev@...r.kernel.org, linuxarm@...wei.com,
        salil.mehta@...wei.com, linyunsheng@...wei.com
Subject: Re: [PATCH net-next] net: hns: use IRQ_NOAUTOEN to avoid irq is
 enabled due to request_irq

From: Barry Song <song.bao.hua@...ilicon.com>
Date: Fri, 11 Sep 2020 13:55:10 +1200

> Rather than doing request_irq and then disabling the irq immediately, it
> should be safer to use IRQ_NOAUTOEN flag for the irq. It removes any gap
> between request_irq() and disable_irq().
> 
> Cc: Salil Mehta <salil.mehta@...wei.com>
> Reviewed-by: Yunsheng Lin <linyunsheng@...wei.com>
> Signed-off-by: Barry Song <song.bao.hua@...ilicon.com>

Applied.