netdev - Re: [PATCH] net: tehuti: switch from 'pci_' to 'dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200912.182730.2087461920010304478.davem@davemloft.net>
Date:   Sat, 12 Sep 2020 18:27:30 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     christophe.jaillet@...adoo.fr
Cc:     kuba@...nel.org, andy@...yhouse.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] net: tehuti: switch from 'pci_' to 'dma_' API

From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Date: Sat, 12 Sep 2020 16:12:32 +0200

> The wrappers in include/linux/pci-dma-compat.h should go away.
> 
> The patch has been generated with the coccinelle script below and has been
> hand modified to replace GFP_ with a correct flag.
> It has been compile tested.
> 
> When memory is allocated in 'bdx_fifo_init()' GFP_ATOMIC must be used
> because it can be called from a '.ndo_set_rx_mode' function. Such functions
> hold the 'netif_addr_lock' spinlock.
> 
>   .ndo_set_rx_mode              (see struct net_device_ops)
>     --> bdx_change_mtu
>       --> bdx_open
>         --> bdx_rx_init
>         --> bdx_tx_init
>           --> bdx_fifo_init
 ...
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Applied.