netdev - Re: [PATCH V2] natsemi: switch from 'pci_' to 'dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200913.141553.1778331693564031642.davem@davemloft.net>
Date:   Sun, 13 Sep 2020 14:15:53 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     christophe.jaillet@...adoo.fr
Cc:     kuba@...nel.org, mst@...hat.com, vaibhavgupta40@...il.com,
        gustavoars@...nel.org, arnd@...db.de, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH V2] natsemi: switch from 'pci_' to 'dma_' API

From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Date: Sun, 13 Sep 2020 07:46:28 +0200

> The wrappers in include/linux/pci-dma-compat.h should go away.
> 
> The patch has been generated with the coccinelle script below and has been
> hand modified to replace GFP_ with a correct flag.
> It has been compile tested.
> 
> When memory is allocated in 'alloc_ring()' (natsemi.c) GFP_KERNEL can be
> used because it is only called from 'netdev_open()', which is a '.ndo_open'
> function. Such function are synchronized with the rtnl_lock() semaphore.
> 
> When memory is allocated in 'ns83820_init_one()' (ns83820.c) GFP_KERNEL can
> be used because it is a probe function and no lock is taken in the between.
 ...
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> If needed, see post from Christoph Hellwig on the kernel-janitors ML:
>    https://marc.info/?l=kernel-janitors&m=158745678307186&w=4
> 
> V2: fix description (duplicated comment and wrong file name)

Applied, thank you.