netdev - Re: [PATCH net-next RFC v4 04/15] devlink: Add reload actions stats to dev get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200914134500.GH2236@nanopsycho.orion>
Date:   Mon, 14 Sep 2020 15:45:00 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Moshe Shemesh <moshe@...lanox.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Jiri Pirko <jiri@...lanox.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, idosch@...sch.org
Subject: Re: [PATCH net-next RFC v4 04/15] devlink: Add reload actions stats
 to dev get

Mon, Sep 14, 2020 at 08:07:51AM CEST, moshe@...lanox.com wrote:
>Expose devlink reload actions stats to the user through devlink dev
>get command.
>
>Examples:
>$ devlink dev show
>pci/0000:82:00.0:
>  reload_action_stats:
>    driver_reinit 2
>    fw_activate 1
>    driver_reinit_no_reset 0
>    fw_activate_no_reset 0
>pci/0000:82:00.1:
>  reload_action_stats:
>    driver_reinit 1
>    fw_activate 1
>    driver_reinit_no_reset 0
>    fw_activate_no_reset 0

I would rather have something like:
   stats:
     reload_action:
       driver_reinit 1
       fw_activate 1
       driver_reinit_no_reset 0
       fw_activate_no_reset 0

Then we can easily extend and add other stats in the tree.


Also, I wonder if these stats could be somehow merged with Ido's metrics
work:
https://github.com/idosch/linux/commits/submit/devlink_metric_rfc_v1

Ido, would it make sense?


>
>$ devlink dev show -jp
>{
>    "dev": {
>        "pci/0000:82:00.0": {
>            "reload_action_stats": [ {
>                    "driver_reinit": 2
>                },{
>                    "fw_activate": 1
>                },{
>                    "driver_reinit_no_reset": 0
>                },{
>                    "fw_activate_no_reset": 0
>                } ]
>        },
>        "pci/0000:82:00.1": {
>            "reload_action_stats": [ {
>                    "driver_reinit": 1
>                },{
>                    "fw_activate": 1
>                },{
>                    "driver_reinit_no_reset": 0
>                },{
>                    "fw_activate_no_reset": 0
>                } ]
>        }
>    }
>}
>

[..]