netdev - Re: [MPTCP] [PATCH net-next v2 01/13] mptcp: rethink 'is writable' conditional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.OSX.2.23.453.2009141056210.57764@ningale-mobl.amr.corp.intel.com>
Date:   Mon, 14 Sep 2020 11:00:26 -0700 (PDT)
From:   Mat Martineau <mathew.j.martineau@...ux.intel.com>
To:     Paolo Abeni <pabeni@...hat.com>
cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, mptcp@...ts.01.org
Subject: Re: [MPTCP] [PATCH net-next v2 01/13] mptcp: rethink 'is writable'
 conditional

On Mon, 14 Sep 2020, Paolo Abeni wrote:

> Currently, when checking for the 'msk is writable' condition, we
> look at the individual subflows write space.
> That works well while we send data via a single subflow, but will
> not as soon as we will enable concurrent xmit on multiple subflows.
>
> With this change msk becomes writable when the following conditions
> hold:
> - the socket has some free write space
> - there is at least a subflow with write free space
>
> Additionally we need to set the NOSPACE bit on all subflows
> before blocking.
>
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>
> ---
> net/mptcp/protocol.c | 71 ++++++++++++++++++++++++++++----------------
> net/mptcp/subflow.c  |  6 ++--
> 2 files changed, 50 insertions(+), 27 deletions(-)
>

Thanks for the v2 Paolo. I've reviewed the series and will tag them all 
so patchwork is updated.

Reviewed-by: Mat Martineau <mathew.j.martineau@...ux.intel.com>

--
Mat Martineau
Intel