netdev - Re: [MPTCP] [PATCH net-next v2 03/13] mptcp: trigger msk processing even for OoO data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.OSX.2.23.453.2009141103170.57764@ningale-mobl.amr.corp.intel.com>
Date:   Mon, 14 Sep 2020 11:03:47 -0700 (PDT)
From:   Mat Martineau <mathew.j.martineau@...ux.intel.com>
To:     Paolo Abeni <pabeni@...hat.com>
cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, mptcp@...ts.01.org
Subject: Re: [MPTCP] [PATCH net-next v2 03/13] mptcp: trigger msk processing
 even for OoO data

On Mon, 14 Sep 2020, Paolo Abeni wrote:

> This is a prerequisite to allow receiving data from multiple
> subflows without re-injection.
>
> Instead of dropping the OoO - "future" data in
> subflow_check_data_avail(), call into __mptcp_move_skbs()
> and let the msk drop that.
>
> To avoid code duplication factor out the mptcp_subflow_discard_data()
> helper.
>
> Note that __mptcp_move_skbs() can now find multiple subflows
> with data avail (comprising to-be-discarded data), so must
> update the byte counter incrementally.
>
> v1 -> v2:
> - fix checkpatch issues (unsigned -> unsigned int)
>
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>
> ---
> net/mptcp/protocol.c | 33 +++++++++++++++----
> net/mptcp/protocol.h |  9 ++++-
> net/mptcp/subflow.c  | 78 ++++++++++++++++++++++++--------------------
> 3 files changed, 78 insertions(+), 42 deletions(-)
>

Reviewed-by: Mat Martineau <mathew.j.martineau@...ux.intel.com>


--
Mat Martineau
Intel