netdev - Re: [PATCH net-next v2 11/13] mptcp: allow picking different xmit subflows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.OSX.2.23.453.2009141109020.57764@ningale-mobl.amr.corp.intel.com>
Date:   Mon, 14 Sep 2020 11:09:21 -0700 (PDT)
From:   Mat Martineau <mathew.j.martineau@...ux.intel.com>
To:     Paolo Abeni <pabeni@...hat.com>
cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, mptcp@...ts.01.org
Subject: Re: [PATCH net-next v2 11/13] mptcp: allow picking different xmit
 subflows

On Mon, 14 Sep 2020, Paolo Abeni wrote:

> Update the scheduler to less trivial heuristic: cache
> the last used subflow, and try to send on it a reasonably
> long burst of data.
>
> When the burst or the subflow send space is exhausted, pick
> the subflow with the lower ratio between write space and
> send buffer - that is, the subflow with the greater relative
> amount of free space.
>
> v1 -> v2:
> - fix 32 bit build breakage due to 64bits div
> - fix checkpath issues (uint64_t -> u64)
>
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>
> ---
> net/mptcp/protocol.c | 111 ++++++++++++++++++++++++++++++++++++-------
> net/mptcp/protocol.h |   6 ++-
> 2 files changed, 99 insertions(+), 18 deletions(-)
>

Reviewed-by: Mat Martineau <mathew.j.martineau@...ux.intel.com>

--
Mat Martineau
Intel