netdev - Re: [PATCH net-next] rcu: prevent RCU_LOCKDEP_WARN() from swallowing the condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200914202122.GC2579423@google.com>
Date:   Mon, 14 Sep 2020 16:21:22 -0400
From:   Joel Fernandes <joel@...lfernandes.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     nikolay@...ulusnetworks.com, davem@...emloft.net,
        netdev@...r.kernel.org, paulmck@...nel.org, josh@...htriplett.org,
        peterz@...radead.org, christian.brauner@...ntu.com,
        rcu@...r.kernel.org, linux-kernel@...r.kernel.org,
        sfr@...b.auug.org.au, roopa@...dia.com
Subject: Re: [PATCH net-next] rcu: prevent RCU_LOCKDEP_WARN() from swallowing
 the condition

On Tue, Sep 08, 2020 at 05:27:51PM -0700, Jakub Kicinski wrote:
> On Tue, 08 Sep 2020 21:15:56 +0300 nikolay@...ulusnetworks.com wrote:
> > Ah, you want to solve it for all. :) 
> > Looks and sounds good to me, 
> > Reviewed-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
> 
> Actually, I give up, lockdep_is_held() is not defined without
> CONFIG_LOCKDEP, let's just go with your patch..

Care to send a patch just for the RCU macro then? Not sure what Dave is
applying but if the net-next tree is not taking the RCU macro change, then
send another one with my tag:

Reviewed-by: Joel Fernandes (Google) <joel@...lfernandes.org>

thanks!

 - Joel