netdev - Re: [PATCH net-next] net: pxa168_eth: remove unused variable 'retval' int pxa168_eth_change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 14 Sep 2020 13:43:49 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     zhangchangzhong@...wei.com
Cc:     kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: pxa168_eth: remove unused variable
 'retval' int pxa168_eth_change_mtu()

From: Zhang Changzhong <zhangchangzhong@...wei.com>
Date: Mon, 14 Sep 2020 21:19:12 +0800

> Fixes the following W=1 kernel build warning(s):
> 
> drivers/net/ethernet/marvell/pxa168_eth.c:1190:6: warning:
>  variable 'retval' set but not used [-Wunused-but-set-variable]
>  1190 |  int retval;
>       |      ^~~~~~
> 
> Function pxa168_eth_change_mtu() always return zero, so variable 'retval'
> is redundant, just remove it.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@...wei.com>

Applied.