lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 14 Sep 2020 14:41:38 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     xie.he.0141@...il.com
Cc:     kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, ms@....tdt.de
Subject: Re: [PATCH net-next] drivers/net/wan/x25_asy: Remove an
 unnecessary x25_type_trans call

From: Xie He <xie.he.0141@...il.com>
Date: Fri, 11 Sep 2020 19:18:07 -0700

> x25_type_trans only needs to be called before we call netif_rx to pass
> the skb to upper layers.
> 
> It does not need to be called before lapb_data_received. The LAPB module
> does not need the fields that are set by calling it.
> 
> In the other two X.25 drivers - lapbether and hdlc_x25. x25_type_trans
> is only called before netif_rx and not before lapb_data_received.
> 
> Cc: Martin Schiller <ms@....tdt.de>
> Signed-off-by: Xie He <xie.he.0141@...il.com>

Applied to net-next, thanks.

Powered by blists - more mailing lists