netdev - Re: [PATCH net] ipv4: Initialize flowi4_multipath

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200914.145535.1102574282222096595.davem@davemloft.net>
Date:   Mon, 14 Sep 2020 14:55:35 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...nel.org
Cc:     netdev@...r.kernel.org, kuba@...nel.org, dsahern@...il.com,
        wenxu@...oud.cn
Subject: Re: [PATCH net] ipv4: Initialize flowi4_multipath_hash in data path

From: David Ahern <dsahern@...nel.org>
Date: Sun, 13 Sep 2020 12:43:39 -0600

> From: David Ahern <dsahern@...il.com>
> 
> flowi4_multipath_hash was added by the commit referenced below for
> tunnels. Unfortunately, the patch did not initialize the new field
> for several fast path lookups that do not initialize the entire flow
> struct to 0. Fix those locations. Currently, flowi4_multipath_hash
> is random garbage and affects the hash value computed by
> fib_multipath_hash for multipath selection.
> 
> Fixes: 24ba14406c5c ("route: Add multipath_hash in flowi_common to make user-define hash")
> Signed-off-by: David Ahern <dsahern@...il.com>
> Cc: wenxu <wenxu@...oud.cn>

Applied and queued up for -stable, thanks David.