lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 15 Sep 2020 01:17:27 +0200
From:   Michal Kubecek <mkubecek@...e.cz>
To:     Dan Murphy <dmurphy@...com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH 0/1] Adding 100base FX support

On Mon, Sep 14, 2020 at 12:06:37PM -0500, Dan Murphy wrote:
> Hello
> 
> I am adding the 100base Fx support for the ethtool.  There are a few PHYs that
> support the Fiber connection and the ethtool should be able to properly display
> that the PHY supports the 100base-FX Full and Half Duplex modes.
> 
> I am adding this support in the ethtool first and then submit the fiber bits
> into the kernel.
> 
> If the kernel needs to be updated first then I can prepare those patches and
> reference them.

Please add the support to kernel first. Otherwise the kernel-userspace
API may change (e.g. if someone adds another mode before yours so that
the constants would be different from your current submission). You
don't have to wait until the change reaches mainline but it should be
accepted at least to the net-next kernel tree.

Some technical notes:

  - please use "[PATCH ethtool]" subject prefix rather than "ethtool: "
    for ethtool utility patches to distinguish them from patches
    targeting kernel ethtool code
  - please update the header file copies in uapi/ directory in
    a separate patch and update all of them to a specific kernel commit
    as requested in
    https://mirrors.edge.kernel.org/pub/software/network/ethtool/devel.html

Michal

> 
> Dan
> 
> Dan Murphy (1):
>   ethtool: Add 100BaseFX half and full duplex link modes
> 
>  ethtool.c            | 6 ++++++
>  netlink/settings.c   | 2 ++
>  uapi/linux/ethtool.h | 2 ++
>  3 files changed, 10 insertions(+)
> 
> -- 
> 2.28.0
> 

Powered by blists - more mailing lists