netdev - Re: [PATCH net] net: sched: initialize with 0 before setting erspan md->u

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200914.165409.912008161467332169.davem@davemloft.net>
Date:   Mon, 14 Sep 2020 16:54:09 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     lucien.xin@...il.com
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        jiri@...nulli.us
Subject: Re: [PATCH net] net: sched: initialize with 0 before setting
 erspan md->u

From: Xin Long <lucien.xin@...il.com>
Date: Sun, 13 Sep 2020 19:43:03 +0800

> In fl_set_erspan_opt(), all bits of erspan md was set 1, as this
> function is also used to set opt MASK. However, when setting for
> md->u.index for opt VALUE, the rest bits of the union md->u will
> be left 1. It would cause to fail the match of the whole md when
> version is 1 and only index is set.
> 
> This patch is to fix by initializing with 0 before setting erspan
> md->u.
> 
> Reported-by: Shuang Li <shuali@...hat.com>
> Fixes: 79b1011cb33d ("net: sched: allow flower to match erspan options")
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Applied and queued up for -stable, thank you.