netdev - Re: [PATCH linux-can-next/flexcan] can: flexcan: fix TDC feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12214d6d-8d42-80ea-4682-1d4d52896c05@pengutronix.de>
Date:   Wed, 16 Sep 2020 00:15:11 +0200
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Michael Walle <michael@...le.cc>
Cc:     Joakim Zhang <qiangqing.zhang@....com>, linux-can@...r.kernel.org,
        dl-linux-imx <linux-imx@....com>, netdev@...r.kernel.org
Subject: Re: [PATCH linux-can-next/flexcan] can: flexcan: fix TDC feature

On 6/29/20 6:23 PM, Michael Walle wrote:
> Hi Marc,
> 
>> I've cleaned up the patches a bit, can you test this branch:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/log/?h=flexcan
> 
> This is working, but as Joakim already said, CAN-FD ISO mode is missing.
> It defaults to non-ISO mode, which is even worse, IMHO.
> 
> But I've also noticed a difference between the original patch and the
> one in that branch. When FD mode is enabled the original patch checks
> the priv->can.controlmode [1], the patch in the branch looks at
> priv->can.ctrlmode_supported instead [2], is that correct?

Nope, I've corrected this.

thanks,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)