netdev - Re: [PATCH v2 bpf-next] selftests/bpf: merge most of test_btf into test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzarJgmvKXwEL+48QvWZRxzx_035ovSFRfVRodZKra+pTw@mail.gmail.com>
Date:   Mon, 14 Sep 2020 22:26:51 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Andrii Nakryiko <andriin@...com>
Cc:     bpf <bpf@...r.kernel.org>, Networking <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH v2 bpf-next] selftests/bpf: merge most of test_btf into test_progs

On Mon, Sep 14, 2020 at 6:43 PM Andrii Nakryiko <andriin@...com> wrote:
>
> Move almost 200 tests from test_btf into test_progs framework to be exercised
> regularly. Pretty-printing tests were left alone and renamed into
> test_btf_pprint because they are very slow and were not even executed by
> default with test_btf.
>
> All the test_btf tests that were moved are modeled as proper sub-tests in
> test_progs framework for ease of debugging and reporting.
>
> No functional or behavioral changes were intended, I tried to preserve
> original behavior as close to the original as possible. `test_progs -v` will
> activate "always_log" flag to emit BTF validation log.
>
> Signed-off-by: Andrii Nakryiko <andriin@...com>
> ---
>
> v1->v2:
>  - pretty-print BTF tests were renamed test_btf -> test_btf_pprint, which
>    allowed GIT to detect that majority of  test_btf code was moved into
>    prog_tests/btf.c; so diff is much-much smaller;
>
>  tools/testing/selftests/bpf/.gitignore        |    2 +-
>  .../bpf/{test_btf.c => prog_tests/btf.c}      | 1069 +----------------
>  tools/testing/selftests/bpf/test_btf_pprint.c |  969 +++++++++++++++
>  3 files changed, 1033 insertions(+), 1007 deletions(-)
>  rename tools/testing/selftests/bpf/{test_btf.c => prog_tests/btf.c} (85%)
>  create mode 100644 tools/testing/selftests/bpf/test_btf_pprint.c

Looks like I forgot to check in a trivial Makefile change (test_btf ->
test_btf_pprint), but I'll hold off until we decided where
pretty-print BTF tests should live.

[...]