netdev - Re: [PATCH v2] mptcp: Fix unsigned 'max_seq' compared with zero in mptcp_data_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f947d64e-5970-7022-1a06-964c7dfbbd03@tessares.net>
Date:   Wed, 16 Sep 2020 14:23:39 +0200
From:   Matthieu Baerts <matthieu.baerts@...sares.net>
To:     Ye Bin <yebin10@...wei.com>, mathew.j.martineau@...ux.intel.com,
        netdev@...r.kernel.org, mptcp@...ts.01.org
Cc:     Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH v2] mptcp: Fix unsigned 'max_seq' compared with zero in
 mptcp_data_queue_ofo

Hi Ye,

Thank you for this v2.

On 16/09/2020 13:41, Ye Bin wrote:
> Fixes coccicheck warnig:
> net/mptcp/protocol.c:164:11-18: WARNING: Unsigned expression compared with zero: max_seq > 0
> 
> Fixes: ab174ad8ef76 ("mptcp: move ooo skbs into msk out of order queue")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Ye Bin <yebin10@...wei.com>
> ---
>   net/mptcp/protocol.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c
> index ef0dd2f23482..3b71f6202524 100644
> --- a/net/mptcp/protocol.c
> +++ b/net/mptcp/protocol.c
> @@ -155,13 +155,14 @@ static void mptcp_data_queue_ofo(struct mptcp_sock *msk, struct sk_buff *skb)
>   {
>   	struct sock *sk = (struct sock *)msk;
>   	struct rb_node **p, *parent;
> +	int space;
>   	u64 seq, end_seq, max_seq;
>   	struct sk_buff *skb1;

In the network subsystem, variables have to be declared following the 
"reverse Xmas tree" order: longest to shortest line length.

Could you then please move your new variable to the end of the list, 
under skb1?

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net