lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 15 Sep 2020 18:16:20 -0700 From: Alexei Starovoitov <alexei.starovoitov@...il.com> To: Song Liu <song@...nel.org> Cc: Martin KaFai Lau <kafai@...com>, bpf <bpf@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Kernel Team <kernel-team@...com>, Networking <netdev@...r.kernel.org>, Yonghong Song <yhs@...com> Subject: Re: [PATCH bpf] bpf: bpf_skc_to_* casting helpers require a NULL check on sk On Tue, Sep 15, 2020 at 2:45 PM Song Liu <song@...nel.org> wrote: > > On Tue, Sep 15, 2020 at 11:32 AM Martin KaFai Lau <kafai@...com> wrote: > > > > The bpf_skc_to_* type casting helpers are available to > > BPF_PROG_TYPE_TRACING. The traced PTR_TO_BTF_ID may be NULL. > > For example, the skb->sk may be NULL. Thus, these casting helpers > > need to check "!sk" also and this patch fixes them. > > > > Fixes: 0d4fad3e57df ("bpf: Add bpf_skc_to_udp6_sock() helper") > > Fixes: 478cfbdf5f13 ("bpf: Add bpf_skc_to_{tcp, tcp_timewait, tcp_request}_sock() helpers") > > Fixes: af7ec1383361 ("bpf: Add bpf_skc_to_tcp6_sock() helper") > > Signed-off-by: Martin KaFai Lau <kafai@...com> > > Acked-by: Song Liu <songliubraving@...com> Applied. Thanks
Powered by blists - more mailing lists