netdev - Re: [PATCH -next] net/sched: Remove unused function qdisc_queue_drop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5b7b6ff1-19ea-33b6-87b7-2cee6db8157d@huawei.com>
Date:   Thu, 17 Sep 2020 09:35:07 +0800
From:   Yuehaibing <yuehaibing@...wei.com>
To:     <davem@...emloft.net>, <kuba@...nel.org>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] net/sched: Remove unused function
 qdisc_queue_drop_head()

Pls drop this duplicate.

On 2020/9/16 22:16, YueHaibing wrote:
> It is not used since commit a09ceb0e0814 ("sched: remove qdisc->drop")
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  include/net/sch_generic.h | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h
> index d60e7c39d60c..6c762457122f 100644
> --- a/include/net/sch_generic.h
> +++ b/include/net/sch_generic.h
> @@ -1047,12 +1047,6 @@ static inline unsigned int __qdisc_queue_drop_head(struct Qdisc *sch,
>  	return 0;
>  }
>  
> -static inline unsigned int qdisc_queue_drop_head(struct Qdisc *sch,
> -						 struct sk_buff **to_free)
> -{
> -	return __qdisc_queue_drop_head(sch, &sch->q, to_free);
> -}
> -
>  static inline struct sk_buff *qdisc_peek_head(struct Qdisc *sch)
>  {
>  	const struct qdisc_skb_head *qh = &sch->q;
>