netdev - Re: [PATCH net-next] ionic: add DIMLIB to Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200917130231.65770423@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 17 Sep 2020 13:02:31 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Shannon Nelson <snelson@...sando.io>
Cc:     netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH net-next] ionic: add DIMLIB to Kconfig

On Thu, 17 Sep 2020 12:08:45 -0700 Shannon Nelson wrote:
> On 9/17/20 12:02 PM, Jakub Kicinski wrote:
> > On Thu, 17 Sep 2020 11:42:43 -0700 Shannon Nelson wrote:  
> >>>> ld.lld: error: undefined symbol: net_dim_get_rx_moderation  
> >>     >>> referenced by ionic_lif.c:52 (drivers/net/ethernet/pensando/ionic/ionic_lif.c:52)
> >>     >>> net/ethernet/pensando/ionic/ionic_lif.o:(ionic_dim_work) in archive drivers/built-in.a  
> >> --  
> > This is going to cut off the commit message when patch is applied.  
> 
> Isn't the trigger a three dash string?  It is only two dashes, not 
> three, and "git am" seems to work correctly for me.  Is there a 
> different mechanism I need to watch out for?

I got a verify_signoff failure on this patch:

Commit a92faed54662 ("ionic: add DIMLIB to Kconfig")
	author Signed-off-by missing
	author email:    snelson@...sando.io

And in the tree I can see the commit got cut off. 

Maybe it's some extra mangling my bot does. In any case, I wanted to
at least give Dave a heads up.