netdev - Re: [PATCH V1 net-next 2/8] net: ena: Add device distinct log prefix to files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 17 Sep 2020 13:12:23 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     saeed@...nel.org
Cc:     shayagr@...zon.com, netdev@...r.kernel.org, dwmw@...zon.com,
        zorik@...zon.com, matua@...zon.com, saeedb@...zon.com,
        msw@...zon.com, aliguori@...zon.com, nafea@...zon.com,
        gtzalik@...zon.com, netanel@...zon.com, alisaidi@...zon.com,
        benh@...zon.com, akiyano@...zon.com, sameehj@...zon.com,
        ndagan@...zon.com, amitbern@...zon.com
Subject: Re: [PATCH V1 net-next 2/8] net: ena: Add device distinct log
 prefix to files

From: Saeed Mahameed <saeed@...nel.org>
Date: Thu, 17 Sep 2020 12:38:28 -0700

> allocated but unregistered netdevices also do not help much as the name
> of the netdev is not assigned yet.
> 
> why don't use dev_info(pci_dev) macors  for low level functions when
> netdev is not available or not allocated yet.

The problem in this case is that they have this huge suite of
functions that operate on a specific ena sub-object.  Most of the time
the associated netdev is fully realized, but in the few calls made
during early probe it is not.

To me it is a serious loss that just because a small number of times
the interface lacks a fully realized netdev object, we can't use the
netdev_*() routines.

Most users aren't going to understand that an error message for PCI
device XyZ means eth0 is having problems.