netdev - Re: [PATCH] i40e: Fix use of uninitialized variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6aaa242f49ccd3824fe4cbb38bada7ccf9add979.camel@intel.com>
Date:   Thu, 17 Sep 2020 21:11:32 +0000
From:   "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
To:     "alex.dewar90@...il.com" <alex.dewar90@...il.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Topel, Bjorn" <bjorn.topel@...el.com>
Subject: Re: [PATCH] i40e: Fix use of uninitialized variable

On Wed, 2020-09-16 at 21:49 +0100, Alex Dewar wrote:
> In i40e_clean_rx_irq_zc(), the variable failure is only set when a
> condition is met, but then its value is used unconditionally. Fix
> this.
> 
> Addresses-Coverity: 1496986 ("Uninitialized value")
> Fixes: 8cbf74149903 ("i40e, xsk: move buffer allocation out of the Rx
> processing loop")
> Signed-off-by: Alex Dewar <alex.dewar90@...il.com>

Thanks for the patch Alex, however, Dan Carpenter has already submitted
a patch for the same reported issue: 
https://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200916143228.GA764370@mwanda/

Thanks,
Tony