netdev - Re: [PATCH bpf-next] bpf: Use hlist_add_head_rcu when linking to local

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPhsuW5ARmNB9wosUPa_xs_gb5jKnZLhOssSXyvhcPhMAKKVYg@mail.gmail.com>
Date:   Thu, 17 Sep 2020 15:15:56 -0700
From:   Song Liu <song@...nel.org>
To:     Martin KaFai Lau <kafai@...com>
Cc:     bpf <bpf@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>,
        Networking <netdev@...r.kernel.org>
Subject: Re: [PATCH bpf-next] bpf: Use hlist_add_head_rcu when linking to local_storage

On Thu, Sep 17, 2020 at 9:57 AM Martin KaFai Lau <kafai@...com> wrote:
>
> The local_storage->list will be traversed by rcu reader in parallel.
> Thus, hlist_add_head_rcu() is needed in bpf_selem_link_storage_nolock().
> This patch fixes it.
>
> This part of the code has recently been refactored in bpf-next
> and this patch makes changes to the new file "bpf_local_storage.c".
> Instead of using the original offending commit in the Fixes tag,
> the commit that created the file "bpf_local_storage.c" is used.
>
> A separate fix has been provided to the bpf tree.
>
> Fixes: 450af8d0f6be ("bpf: Split bpf_local_storage to bpf_sk_storage")
> Signed-off-by: Martin KaFai Lau <kafai@...com>

Acked-by: Song Liu <songliubraving@...com>