netdev - Re: [PATCH v3] hv_netvsc: Add validation for untrusted Hyper-V values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200917.162151.1659729424033781238.davem@davemloft.net>
Date:   Thu, 17 Sep 2020 16:21:51 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     parri.andrea@...il.com
Cc:     linux-kernel@...r.kernel.org, kys@...rosoft.com,
        haiyangz@...rosoft.com, sthemmin@...rosoft.com, wei.liu@...nel.org,
        linux-hyperv@...r.kernel.org, lkmlabelt@...il.com,
        mikelley@...rosoft.com, skarade@...rosoft.com,
        juvazq@...rosoft.com, kuba@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v3] hv_netvsc: Add validation for untrusted Hyper-V
 values

From: "Andrea Parri (Microsoft)" <parri.andrea@...il.com>
Date: Wed, 16 Sep 2020 11:47:27 +0200

> From: Andres Beltran <lkmlabelt@...il.com>
> 
> For additional robustness in the face of Hyper-V errors or malicious
> behavior, validate all values that originate from packets that Hyper-V
> has sent to the guest in the host-to-guest ring buffer. Ensure that
> invalid values cannot cause indexing off the end of an array, or
> subvert an existing validation via integer overflow. Ensure that
> outgoing packets do not have any leftover guest memory that has not
> been zeroed out.
> 
> Signed-off-by: Andres Beltran <lkmlabelt@...il.com>
> Co-developed-by: Andrea Parri (Microsoft) <parri.andrea@...il.com>
> Signed-off-by: Andrea Parri (Microsoft) <parri.andrea@...il.com>

Applied, thank you.