netdev - Re: [PATCH net-next 1/1] net/smc: fix double kfree in smc_listen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200917.180421.267575960727747646.davem@davemloft.net>
Date:   Thu, 17 Sep 2020 18:04:21 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     kgraul@...ux.ibm.com
Cc:     netdev@...r.kernel.org, linux-s390@...r.kernel.org,
        heiko.carstens@...ibm.com, raspl@...ux.ibm.com,
        ubraun@...ux.ibm.com
Subject: Re: [PATCH net-next 1/1] net/smc: fix double kfree in
 smc_listen_work()

From: Karsten Graul <kgraul@...ux.ibm.com>
Date: Thu, 17 Sep 2020 22:46:02 +0200

> From: Ursula Braun <ubraun@...ux.ibm.com>
> 
> If smc_listen_rmda_finish() returns with an error, the storage
> addressed by 'buf' is freed a second time.
> Consolidate freeing under a common label and jump to that label.
> 
> Fixes: 6bb14e48ee8d ("net/smc: dynamic allocation of CLC proposal buffer")
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Ursula Braun <ubraun@...ux.ibm.com>
> Signed-off-by: Karsten Graul <kgraul@...ux.ibm.com>

Applied.