lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 Sep 2020 18:06:38 -0700 (PDT) From: David Miller <davem@...emloft.net> To: f.fainelli@...il.com Cc: netdev@...r.kernel.org, andrew@...n.ch, hkallweit1@...il.com, kuba@...nel.org Subject: Re: [PATCH net-next 1/2] net: mdio: mdio-bcm-unimac: Turn on PHY clock before dummy read From: Florian Fainelli <f.fainelli@...il.com> Date: Thu, 17 Sep 2020 17:18:42 -0700 > > > On 9/17/2020 4:40 PM, David Miller wrote: >> From: Florian Fainelli <f.fainelli@...il.com> >> Date: Wed, 16 Sep 2020 13:44:14 -0700 >> >>> @@ -160,6 +160,7 @@ static int unimac_mdio_reset(struct mii_bus *bus) >>> { >>> struct device_node *np = bus->dev.of_node; >>> struct device_node *child; >>> + struct clk *clk; >>> u32 read_mask = 0; >>> int addr; >> Please preserve the reverse christmas tree ordering of these local >> variables, thank you. > > Looks like I used the same thread for all patches, the most recent is > this one: > > https://patchwork.ozlabs.org/project/netdev/patch/20200917020413.2313461-1-f.fainelli@gmail.com/ > > and is the one I would like to see you apply if you are happy with it. Ok I'll just give Andrew a chance to reply to your most recent comment in that thread.
Powered by blists - more mailing lists