netdev - Re: [PATCH net v2] hinic: fix potential resource leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200917.170414.150393020289404711.davem@davemloft.net>
Date:   Thu, 17 Sep 2020 17:04:14 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     liwei391@...wei.com
Cc:     luobin9@...wei.com, kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, huawei.libin@...wei.com,
        guohanjun@...wei.com
Subject: Re: [PATCH net v2] hinic: fix potential resource leak

From: Wei Li <liwei391@...wei.com>
Date: Thu, 17 Sep 2020 20:29:50 +0800

> In rx_request_irq(), it will just return what irq_set_affinity_hint()
> returns. If it is failed, the napi and irq requested are not freed
> properly. So add exits for failures to handle these.
> 
> Signed-off-by: Wei Li <liwei391@...wei.com>
> ---
> v1 -> v2:
>  - Free irq as well when irq_set_affinity_hint() fails.

Applied, thank you.