netdev - Re: [PATCH bpf v1] tools/bpftool: support passing BPFTOOL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPGftE9+xn4y6vY5LH3txVmMZ7k6C+QAdULv6CR5EWAJB54=cg@mail.gmail.com>
Date:   Thu, 17 Sep 2020 18:08:04 -0700
From:   Tony Ambardar <tony.ambardar@...il.com>
To:     Song Liu <song@...nel.org>
Cc:     Quentin Monnet <quentin@...valent.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH bpf v1] tools/bpftool: support passing BPFTOOL_VERSION to make

On Thu, 17 Sep 2020 at 16:27, Song Liu <song@...nel.org> wrote:
>
> On Thu, Sep 17, 2020 at 7:58 AM Quentin Monnet <quentin@...valent.com> wrote:
> >
> > On 17/09/2020 12:58, Tony Ambardar wrote:
> > > This change facilitates out-of-tree builds, packaging, and versioning for
> > > test and debug purposes. Defining BPFTOOL_VERSION allows self-contained
> > > builds within the tools tree, since it avoids use of the 'kernelversion'
> > > target in the top-level makefile, which would otherwise pull in several
> > > other includes from outside the tools tree.
> > >
> > > Signed-off-by: Tony Ambardar <Tony.Ambardar@...il.com>
> >
> > Acked-by: Quentin Monnet <quentin@...valent.com>
>
> Acked-by: Song Liu <songliubraving@...com>

I should clarify for those performing stand-alone builds that a few
items are still required from outside the tools/ tree:
kernel/bpf/disasm.[ch] and scripts/bpf_helpers_doc.py. Not sure that's
worth updating the commit description however.