netdev - Re: [PATCH] vhost-vdpa: fix memory leak in error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKXe6SKAFqOQtxbLwA4WA8aEBB-8EtEPvrpsNYU8rLUt9t6zSQ@mail.gmail.com>
Date:   Fri, 18 Sep 2020 20:58:37 +0800
From:   Li Qiang <liq3ea@...il.com>
To:     Li Qiang <liq3ea@....com>
Cc:     "Michael S. Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        kvm list <kvm@...r.kernel.org>,
        virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vhost-vdpa: fix memory leak in error path

Any status update?

Thanks,
Li Qiang

Li Qiang <liq3ea@....com> 于2020年9月9日周三 下午11:42写道：
>
> Free the 'page_list' when the 'npages' is zero.
>
> Signed-off-by: Li Qiang <liq3ea@....com>
> ---
>  drivers/vhost/vdpa.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
> index 3fab94f88894..6a9fcaf1831d 100644
> --- a/drivers/vhost/vdpa.c
> +++ b/drivers/vhost/vdpa.c
> @@ -609,8 +609,10 @@ static int vhost_vdpa_process_iotlb_update(struct vhost_vdpa *v,
>                 gup_flags |= FOLL_WRITE;
>
>         npages = PAGE_ALIGN(msg->size + (iova & ~PAGE_MASK)) >> PAGE_SHIFT;
> -       if (!npages)
> -               return -EINVAL;
> +       if (!npages) {
> +               ret = -EINVAL;
> +               goto free_page;
> +       }
>
>         mmap_read_lock(dev->mm);
>
> @@ -666,6 +668,8 @@ static int vhost_vdpa_process_iotlb_update(struct vhost_vdpa *v,
>                 atomic64_sub(npages, &dev->mm->pinned_vm);
>         }
>         mmap_read_unlock(dev->mm);
> +
> +free_page:
>         free_page((unsigned long)page_list);
>         return ret;
>  }
> --
> 2.25.1
>