netdev - Re: [PATCH net-next 05/11] net: dsa: seville: remove unused defines for the mdio controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 18 Sep 2020 17:46:45 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, yangbo.lu@....com,
        xiaoliang.yang_1@....com, UNGLinuxDriver@...rochip.com,
        claudiu.manoil@....com, andrew@...n.ch, vivien.didelot@...il.com,
        f.fainelli@...il.com, kuba@...nel.org
Subject: Re: [PATCH net-next 05/11] net: dsa: seville: remove unused defines
 for the mdio controller

On 18/09/2020 13:57:47+0300, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@....com>
> 
> Some definitions were likely copied from
> drivers/net/mdio/mdio-mscc-miim.c.
> 
> They are not necessary, remove them.

Seeing that the mdio controller is probably the same, couldn't
mdio-mscc-miim be reused?

> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> ---
>  drivers/net/dsa/ocelot/seville_vsc9953.c | 11 -----------
>  1 file changed, 11 deletions(-)
> 
> diff --git a/drivers/net/dsa/ocelot/seville_vsc9953.c b/drivers/net/dsa/ocelot/seville_vsc9953.c
> index dfc9a1b2a504..0b6ceec85891 100644
> --- a/drivers/net/dsa/ocelot/seville_vsc9953.c
> +++ b/drivers/net/dsa/ocelot/seville_vsc9953.c
> @@ -16,23 +16,12 @@
>  #define VSC9953_VCAP_IS2_ENTRY_WIDTH		376
>  #define VSC9953_VCAP_PORT_CNT			10
>  
> -#define MSCC_MIIM_REG_STATUS			0x0
> -#define		MSCC_MIIM_STATUS_STAT_BUSY	BIT(3)
> -#define MSCC_MIIM_REG_CMD			0x8
>  #define		MSCC_MIIM_CMD_OPR_WRITE		BIT(1)
>  #define		MSCC_MIIM_CMD_OPR_READ		BIT(2)
>  #define		MSCC_MIIM_CMD_WRDATA_SHIFT	4
>  #define		MSCC_MIIM_CMD_REGAD_SHIFT	20
>  #define		MSCC_MIIM_CMD_PHYAD_SHIFT	25
>  #define		MSCC_MIIM_CMD_VLD		BIT(31)
> -#define MSCC_MIIM_REG_DATA			0xC
> -#define		MSCC_MIIM_DATA_ERROR		(BIT(16) | BIT(17))
> -
> -#define MSCC_PHY_REG_PHY_CFG		0x0
> -#define		PHY_CFG_PHY_ENA		(BIT(0) | BIT(1) | BIT(2) | BIT(3))
> -#define		PHY_CFG_PHY_COMMON_RESET BIT(4)
> -#define		PHY_CFG_PHY_RESET	(BIT(5) | BIT(6) | BIT(7) | BIT(8))
> -#define MSCC_PHY_REG_PHY_STATUS		0x4
>  
>  static const u32 vsc9953_ana_regmap[] = {
>  	REG(ANA_ADVLEARN,			0x00b500),
> -- 
> 2.25.1
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com