netdev - Re: [PATCH -next 2/9] rtlwifi: rtl8192c: fix comparison to bool warning in phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <34dceb4c-8a5d-a0f1-f572-d05a9b8b9b76@lwfinger.net>
Date:   Fri, 18 Sep 2020 15:47:05 -0500
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Zheng Bin <zhengbin13@...wei.com>, pkshih@...ltek.com,
        kvalo@...eaurora.org, davem@...emloft.net, kuba@...nel.org,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     yi.zhang@...wei.com
Subject: Re: [PATCH -next 2/9] rtlwifi: rtl8192c: fix comparison to bool
 warning in phy_common.c

On 9/18/20 5:24 AM, Zheng Bin wrote:
> Fixes coccicheck warning:
> 
> drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c:1106:14-18: WARNING: Comparison to bool
> 
> Signed-off-by: Zheng Bin <zhengbin13@...wei.com>
> ---
>   drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Larry Finger <Larry.Finger@...inger.net>

Larry

> 
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c
> index fc6c81291cf5..6a3deca404b9 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c
> @@ -1103,7 +1103,7 @@ static void _rtl92c_phy_path_adda_on(struct ieee80211_hw *hw,
>   	u32 i;
> 
>   	pathon = is_patha_on ? 0x04db25a4 : 0x0b1b25a4;
> -	if (false == is2t) {
> +	if (!is2t) {
>   		pathon = 0x0bdb25a0;
>   		rtl_set_bbreg(hw, addareg[0], MASKDWORD, 0x0b1b25a0);
>   	} else {
> --
> 2.26.0.106.g9fadedd
>