netdev - Re: [PATCH -next 4/9] rtlwifi: rtl8821ae: fix comparison to bool warning in hw.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a94ceca0-1be0-41bb-30fb-855ffd0013bb@lwfinger.net>
Date:   Fri, 18 Sep 2020 15:47:56 -0500
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Zheng Bin <zhengbin13@...wei.com>, pkshih@...ltek.com,
        kvalo@...eaurora.org, davem@...emloft.net, kuba@...nel.org,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     yi.zhang@...wei.com
Subject: Re: [PATCH -next 4/9] rtlwifi: rtl8821ae: fix comparison to bool
 warning in hw.c

On 9/18/20 5:25 AM, Zheng Bin wrote:
> Fixes coccicheck warning:
> 
> drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c:1897:5-13: WARNING: Comparison to bool
> 
> Signed-off-by: Zheng Bin <zhengbin13@...wei.com>
> ---
>   drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Larry Finger <Larry.Finger@...inger.net>

Larry

> 
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
> index b2e5b9fda669..33ffc24d3675 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
> @@ -1894,7 +1894,7 @@ int rtl8821ae_hw_init(struct ieee80211_hw *hw)
>   	}
> 
>   	rtstatus = _rtl8821ae_init_mac(hw);
> -	if (rtstatus != true) {
> +	if (!rtstatus) {
>   		pr_err("Init MAC failed\n");
>   		err = 1;
>   		return err;
> --
> 2.26.0.106.g9fadedd
>