netdev - Re: [PATCH -next 9/9] rtlwifi: rtl8723be: fix comparison to bool warning in hw.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <09ee4bfd-d010-a185-7050-702a9e9d8bd7@lwfinger.net>
Date:   Fri, 18 Sep 2020 15:49:46 -0500
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Zheng Bin <zhengbin13@...wei.com>, pkshih@...ltek.com,
        kvalo@...eaurora.org, davem@...emloft.net, kuba@...nel.org,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     yi.zhang@...wei.com
Subject: Re: [PATCH -next 9/9] rtlwifi: rtl8723be: fix comparison to bool
 warning in hw.c

On 9/18/20 5:25 AM, Zheng Bin wrote:
> Fixes coccicheck warning:
> 
> drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c:861:6-35: WARNING: Comparison to bool
> 
> Signed-off-by: Zheng Bin <zhengbin13@...wei.com>
> ---
>   drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Larry Finger <Larry.Finger@...inger.net>

Larry

> 
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c
> index 3c7ba8214daf..0748aedce2ad 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c
> @@ -858,7 +858,7 @@ static bool _rtl8723be_init_mac(struct ieee80211_hw *hw)
>   	rtl_write_word(rtlpriv, REG_CR, 0x2ff);
> 
>   	if (!rtlhal->mac_func_enable) {
> -		if (_rtl8723be_llt_table_init(hw) == false)
> +		if (!_rtl8723be_llt_table_init(hw))
>   			return false;
>   	}
> 
> --
> 2.26.0.106.g9fadedd
>