netdev - 答复: [PATCH net-next] net: ethernet: Remove set but not used variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7adfc7d14e2a4284a0b99f428d2836b0@huawei.com>
Date:   Sat, 19 Sep 2020 01:31:38 +0000
From:   zhengyongjun <zhengyongjun3@...wei.com>
To:     David Miller <davem@...emloft.net>
CC:     "fmanlunas@...vell.com" <fmanlunas@...vell.com>,
        "sburla@...vell.com" <sburla@...vell.com>,
        "dchickles@...vell.com" <dchickles@...vell.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: 答复: [PATCH net-next] net: ethernet: Remove set but not used variable

I have fix it and send back the patch to you. Thank you very much.

-----邮件原件-----
发件人: David Miller [mailto:davem@...emloft.net] 
发送时间: 2020年9月19日 5:30
收件人: zhengyongjun <zhengyongjun3@...wei.com>
抄送: fmanlunas@...vell.com; sburla@...vell.com; dchickles@...vell.com; kuba@...nel.org; netdev@...r.kernel.org; linux-kernel@...r.kernel.org
主题: Re: [PATCH net-next] net: ethernet: Remove set but not used variable

From: Zheng Yongjun <zhengyongjun3@...wei.com>
Date: Fri, 18 Sep 2020 16:39:38 +0800

> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/net/ethernet/cavium/liquidio/octeon_device.c: In function lio_pci_readq:
> drivers/net/ethernet/cavium/liquidio/octeon_device.c:1327:6: warning: variable ʽval32ʼ set but not used [-Wunused-but-set-variable]
> 
> drivers/net/ethernet/cavium/liquidio/octeon_device.c: In function lio_pci_writeq:
> drivers/net/ethernet/cavium/liquidio/octeon_device.c:1358:6: warning: variable ʽval32ʼ set but not used [-Wunused-but-set-variable]
> 
> these variable is never used, so remove it.
> 
> Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com>

The proper subsystem prefix for these changes is just "liquidio: ".

For changes to a specific driver it is not appropriate to use
"net: ethernet: " or similar.

Please fix up your Subject line and resubmit.

Thank you.