netdev - RE: [PATCH net-next v2 3/8] devlink: Prepare code to fill multiple port function attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BY5PR12MB432230C8148A20627B98A9FADC3C0@BY5PR12MB4322.namprd12.prod.outlook.com>
Date:   Sat, 19 Sep 2020 05:41:01 +0000
From:   Parav Pandit <parav@...dia.com>
To:     Jacob Keller <jacob.e.keller@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     Jiri Pirko <jiri@...dia.com>
Subject: RE: [PATCH net-next v2 3/8] devlink: Prepare code to fill multiple
 port function attributes



> From: Jacob Keller <jacob.e.keller@...el.com>
> Sent: Saturday, September 19, 2020 4:24 AM
> 
> 
> On 9/17/2020 8:35 PM, Parav Pandit wrote:
> > Hi Jacob,
> >
> >> From: Jacob Keller <jacob.e.keller@...el.com>
> >> Sent: Friday, September 18, 2020 12:29 AM
> >>
> >>
> >> We lost this comment in the move it looks like. I think it's still
> >> useful to keep for clarity of why we're converting -EOPNOTSUPP in the
> return.
> > You are right. It is a useful comment.
> > However, it is already covered in include/net/devlink.h in the standard
> comment of the callback function.
> > For new driver implementation, looking there will be more useful.
> > So I guess its ok to drop from here.
> >
> 
> Yea if it's still in the header I don't think it's too important to keep here.
>
Alright. Will keep in the header.
Thanks.
 
> Thanks!
> -Jake