netdev - Re: [PATCH] net: ipv6: fix kconfig dependency warning for IPV6_SEG6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200918.174544.1980981472619221408.davem@davemloft.net>
Date:   Fri, 18 Sep 2020 17:45:44 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     fazilyildiran@...il.com
Cc:     david.lebrun@...ouvain.be, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, paul@...zz.com, jeho@...utexas.edu
Subject: Re: [PATCH] net: ipv6: fix kconfig dependency warning for
 IPV6_SEG6_HMAC

From: Necip Fazil Yildiran <fazilyildiran@...il.com>
Date: Thu, 17 Sep 2020 19:46:43 +0300

> When IPV6_SEG6_HMAC is enabled and CRYPTO is disabled, it results in the
> following Kbuild warning:
> 
> WARNING: unmet direct dependencies detected for CRYPTO_HMAC
>   Depends on [n]: CRYPTO [=n]
>   Selected by [y]:
>   - IPV6_SEG6_HMAC [=y] && NET [=y] && INET [=y] && IPV6 [=y]
> 
> WARNING: unmet direct dependencies detected for CRYPTO_SHA1
>   Depends on [n]: CRYPTO [=n]
>   Selected by [y]:
>   - IPV6_SEG6_HMAC [=y] && NET [=y] && INET [=y] && IPV6 [=y]
> 
> WARNING: unmet direct dependencies detected for CRYPTO_SHA256
>   Depends on [n]: CRYPTO [=n]
>   Selected by [y]:
>   - IPV6_SEG6_HMAC [=y] && NET [=y] && INET [=y] && IPV6 [=y]
> 
> The reason is that IPV6_SEG6_HMAC selects CRYPTO_HMAC, CRYPTO_SHA1, and
> CRYPTO_SHA256 without depending on or selecting CRYPTO while those configs
> are subordinate to CRYPTO.
> 
> Honor the kconfig menu hierarchy to remove kconfig dependency warnings.
> 
> Fixes: bf355b8d2c30 ("ipv6: sr: add core files for SR HMAC support")
> Signed-off-by: Necip Fazil Yildiran <fazilyildiran@...il.com>

Applied and queued up for -stable, thank you.