netdev - Re: [RFC PATCH 1/9] net: dsa: deny enslaving 802.1Q upper to VLAN-aware bridge from PRECHANGEUPPER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dbe191ee-aef5-2e32-c4a6-d18b3d73ebe3@gmail.com>
Date:   Sat, 19 Sep 2020 19:33:22 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org,
        davem@...emloft.net
Cc:     andrew@...n.ch, vivien.didelot@...il.com, idosch@...sch.org,
        jiri@...nulli.us, kurt.kanzenbach@...utronix.de, kuba@...nel.org
Subject: Re: [RFC PATCH 1/9] net: dsa: deny enslaving 802.1Q upper to
 VLAN-aware bridge from PRECHANGEUPPER



On 9/19/2020 6:47 PM, Vladimir Oltean wrote:
> There doesn't seem to be any strong technical reason for doing it this
> way, but we'll be adding more checks for invalid upper device
> configurations, and it will be easier to have them all grouped under
> PRECHANGEUPPER.
> 
> Tested that it still works:
> ip link set br0 type bridge vlan_filtering 1
> ip link add link swp2 name swp2.100 type vlan id 100
> ip link set swp2.100 master br0
> [   20.321312] br0: port 5(swp2.100) entered blocking state
> [   20.326711] br0: port 5(swp2.100) entered disabled state
> Error: dsa_core: Cannot enslave VLAN device into VLAN aware bridge.
> [   20.346549] br0: port 5(swp2.100) entered blocking state
> [   20.351957] br0: port 5(swp2.100) entered disabled state
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian