lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 19 Sep 2020 19:33:32 -0700 From: Florian Fainelli <f.fainelli@...il.com> To: Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org, davem@...emloft.net Cc: andrew@...n.ch, vivien.didelot@...il.com, idosch@...sch.org, jiri@...nulli.us, kurt.kanzenbach@...utronix.de, kuba@...nel.org Subject: Re: [RFC PATCH 2/9] net: dsa: rename dsa_slave_upper_vlan_check to something more suggestive On 9/19/2020 6:47 PM, Vladimir Oltean wrote: > We'll be adding a new check in the PRECHANGEUPPER notifier, where we'll > need to check some VLAN uppers. It is hard to do that when there is > already a function named dsa_slave_upper_vlan_check. So rename this one. > > Not to mention that this function probably shouldn't have started with > "dsa_slave_" in the first place, since the struct net_device argument > isn't a DSA slave, but an 8021q upper of one. > > Signed-off-by: Vladimir Oltean <vladimir.oltean@....com> Reviewed-by: Florian Fainelli <f.fainelli@...il.com> -- Florian
Powered by blists - more mailing lists