netdev - Re: [RFC PATCH 6/9] net: dsa: allow 8021q uppers while the bridge has vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 19 Sep 2020 19:40:22 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org,
        davem@...emloft.net
Cc:     andrew@...n.ch, vivien.didelot@...il.com, idosch@...sch.org,
        jiri@...nulli.us, kurt.kanzenbach@...utronix.de, kuba@...nel.org
Subject: Re: [RFC PATCH 6/9] net: dsa: allow 8021q uppers while the bridge has
 vlan_filtering=0



On 9/19/2020 6:47 PM, Vladimir Oltean wrote:
> When the bridge has VLAN awareness disabled there isn't any duplication
> of functionality, since the bridge does not process VLAN. Don't deny
> adding 8021q uppers to DSA switch ports in that case. The switch is
> supposed to simply pass traffic leaving the VLAN tag as-is, and the
> stack will happily strip the VLAN tag for all 8021q uppers that exist.
> 
> We need to ensure that there are no 8021q uppers when the user attempts
> to enable bridge vlan_filtering.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian