netdev - Re: [RFC PATCH 8/9] net: dsa: tag_8021q: add VLANs to the master interface too

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 19 Sep 2020 19:44:38 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org,
        davem@...emloft.net
Cc:     andrew@...n.ch, vivien.didelot@...il.com, idosch@...sch.org,
        jiri@...nulli.us, kurt.kanzenbach@...utronix.de, kuba@...nel.org
Subject: Re: [RFC PATCH 8/9] net: dsa: tag_8021q: add VLANs to the master
 interface too



On 9/19/2020 6:47 PM, Vladimir Oltean wrote:
> The whole purpose of tag_8021q is to send VLAN-tagged traffic to the
> CPU, from which the driver can decode the source port and switch id.
> 
> Currently this only works if the VLAN filtering on the master is
> disabled. Change that by explicitly adding code to tag_8021q.c to add
> the VLANs corresponding to the tags to the filter of the master
> interface.
> 
> Because we now need to call vlan_vid_add, then we also need to hold the
> RTNL mutex. Propagate that requirement to the callers of dsa_8021q_setup
> and modify the existing call sites as appropriate. Note that one call
> path, sja1105_best_effort_vlan_filtering_set -> sja1105_vlan_filtering
> -> sja1105_setup_8021q_tagging, was already holding this lock.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian