netdev - Re: [PATCH net] net: wilc1000: clean up resource in error path of init mon interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200921130228.7C1E1C433CB@smtp.codeaurora.org>
Date:   Mon, 21 Sep 2020 13:02:28 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Huang Guobin <huangguobin4@...wei.com>
Cc:     <ajay.kathat@...rochip.com>, <claudiu.beznea@...rochip.com>,
        <davem@...emloft.net>, <kuba@...nel.org>,
        <gregkh@...uxfoundation.org>, <linux-wireless@...r.kernel.org>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] net: wilc1000: clean up resource in error path of
 init
 mon interface

Huang Guobin <huangguobin4@...wei.com> wrote:

> The wilc_wfi_init_mon_int() forgets to clean up resource when
> register_netdevice() failed. Add the missed call to fix it.
> And the return value of netdev_priv can't be NULL, so remove
> the unnecessary error handling.
> 
> Fixes: 588713006ea4 ("staging: wilc1000: avoid the use of 'wilc_wfi_mon' static variable")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Huang Guobin <huangguobin4@...wei.com>

Patch applied to wireless-drivers-next.git, thanks.

55bd14997867 net: wilc1000: clean up resource in error path of init mon interface

-- 
https://patchwork.kernel.org/patch/11782369/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches