netdev - Re: [PATCH net-next 06/16] net: bridge: mcast: rename br

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Sep 2020 21:30:18 +0800
From:   kernel test robot <lkp@...el.com>
To:     Nikolay Aleksandrov <razor@...ckwall.org>, netdev@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, roopa@...dia.com, davem@...emloft.net,
        bridge@...ts.linux-foundation.org,
        Nikolay Aleksandrov <nikolay@...dia.com>,
        Marek Lindner <mareklindner@...mailbox.ch>,
        Simon Wunderlich <sw@...onwunderlich.de>,
        Sven Eckelmann <sven@...fation.org>,
        b.a.t.m.a.n@...ts.open-mesh.org
Subject: Re: [PATCH net-next 06/16] net: bridge: mcast: rename br_ip's u
 member to dst

Hi Nikolay,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Nikolay-Aleksandrov/net-bridge-mcast-IGMPv3-MLDv2-fast-path-part-2/20200921-185933
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 3cec0369905d086a56a7515f3449982403057599
config: riscv-allyesconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   net/batman-adv/multicast.c: In function 'batadv_mcast_mla_br_addr_cpy':
>> net/batman-adv/multicast.c:564:20: error: 'const struct br_ip' has no member named 'u'
     564 |   ip_eth_mc_map(src->u.ip4, dst);
         |                    ^~
   net/batman-adv/multicast.c:567:23: error: 'const struct br_ip' has no member named 'u'
     567 |   ipv6_eth_mc_map(&src->u.ip6, dst);
         |                       ^~

# https://github.com/0day-ci/linux/commit/195fb98d13499e5a7c5a2a750e6a7e0cbcfaccdc
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Nikolay-Aleksandrov/net-bridge-mcast-IGMPv3-MLDv2-fast-path-part-2/20200921-185933
git checkout 195fb98d13499e5a7c5a2a750e6a7e0cbcfaccdc
vim +564 net/batman-adv/multicast.c

c5caf4ef34e277 Linus Lüssing  2014-02-15  548  
687937ab34896d Linus Lüssing  2016-05-10  549  /**
7e9a8c2ce7c5f8 Sven Eckelmann 2017-12-02  550   * batadv_mcast_mla_br_addr_cpy() - copy a bridge multicast address
687937ab34896d Linus Lüssing  2016-05-10  551   * @dst: destination to write to - a multicast MAC address
687937ab34896d Linus Lüssing  2016-05-10  552   * @src: source to read from - a multicast IP address
687937ab34896d Linus Lüssing  2016-05-10  553   *
687937ab34896d Linus Lüssing  2016-05-10  554   * Converts a given multicast IPv4/IPv6 address from a bridge
687937ab34896d Linus Lüssing  2016-05-10  555   * to its matching multicast MAC address and copies it into the given
687937ab34896d Linus Lüssing  2016-05-10  556   * destination buffer.
687937ab34896d Linus Lüssing  2016-05-10  557   *
687937ab34896d Linus Lüssing  2016-05-10  558   * Caller needs to make sure the destination buffer can hold
687937ab34896d Linus Lüssing  2016-05-10  559   * at least ETH_ALEN bytes.
687937ab34896d Linus Lüssing  2016-05-10  560   */
687937ab34896d Linus Lüssing  2016-05-10  561  static void batadv_mcast_mla_br_addr_cpy(char *dst, const struct br_ip *src)
687937ab34896d Linus Lüssing  2016-05-10  562  {
687937ab34896d Linus Lüssing  2016-05-10  563  	if (src->proto == htons(ETH_P_IP))
687937ab34896d Linus Lüssing  2016-05-10 @564  		ip_eth_mc_map(src->u.ip4, dst);
687937ab34896d Linus Lüssing  2016-05-10  565  #if IS_ENABLED(CONFIG_IPV6)
687937ab34896d Linus Lüssing  2016-05-10  566  	else if (src->proto == htons(ETH_P_IPV6))
687937ab34896d Linus Lüssing  2016-05-10  567  		ipv6_eth_mc_map(&src->u.ip6, dst);
687937ab34896d Linus Lüssing  2016-05-10  568  #endif
687937ab34896d Linus Lüssing  2016-05-10  569  	else
687937ab34896d Linus Lüssing  2016-05-10  570  		eth_zero_addr(dst);
687937ab34896d Linus Lüssing  2016-05-10  571  }
687937ab34896d Linus Lüssing  2016-05-10  572  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (66214 bytes)