netdev - Re: [PATCH 1/9 next] mm:process_vm_access Call import_iovec() instead of rw_copy_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200921140935.GA24515@infradead.org>
Date:   Mon, 21 Sep 2020 15:09:35 +0100
From:   Christoph Hellwig <hch@...radead.org>
To:     David Laight <David.Laight@...lab.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "io-uring@...r.kernel.org" <io-uring@...r.kernel.org>,
        Jens Axboe <axboe@...nel.dk>,
        "David S. Miller" <davem@...emloft.net>,
        Al Viro <viro@...iv.linux.org.uk>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH 1/9 next] mm:process_vm_access Call import_iovec()
 instead of rw_copy_check_uvector()

On Tue, Sep 15, 2020 at 02:55:08PM +0000, David Laight wrote:
> 
> This is the only direct call of rw_copy_check_uvector().
> Removing it lets rw_copy_check_uvector() be inlined into
> import_iovec() and the horrid calling conventions fixed.

This looks sensible, but as-is will create a warning when actually
this code.

This is the variant I picked up as a prep patch for the compat
iovec handling, which passes the relevant LTP tests:

http://git.infradead.org/users/hch/misc.git/commitdiff/9e3cf5d0f13572310354bf6c62e1feb9fb232266