netdev - Re: [PATCH net-next 3/3] dpaa2-mac: add PCS support through the Lynx module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200921170721.GE3717417@lunn.ch>
Date:   Mon, 21 Sep 2020 19:07:21 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Ioana Ciornei <ioana.ciornei@....com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, linux@...linux.org.uk
Subject: Re: [PATCH net-next 3/3] dpaa2-mac: add PCS support through the Lynx
 module

On Mon, Sep 21, 2020 at 07:20:31PM +0300, Ioana Ciornei wrote:
> +static void dpaa2_pcs_destroy(struct dpaa2_mac *mac)
> +{
> +	struct lynx_pcs *pcs = mac->pcs;
> +
> +	if (pcs) {
> +		put_device(&pcs->mdio->dev);
> +		lynx_pcs_destroy(pcs);
> +		mac->pcs = NULL;

Hi Ioana

Maybe the put_device() should come after the destroy? It is then the
reverse of the creation.

	Andrew