netdev - Re: [PATCH net-next 0/2] Devlink regions for SJA1105 DSA driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200921190327.GG3717417@lunn.ch>
Date:   Mon, 21 Sep 2020 21:03:27 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Vladimir Oltean <vladimir.oltean@....com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "vivien.didelot@...il.com" <vivien.didelot@...il.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "cphealy@...il.com" <cphealy@...il.com>,
        "jiri@...dia.com" <jiri@...dia.com>
Subject: Re: [PATCH net-next 0/2] Devlink regions for SJA1105 DSA driver

On Mon, Sep 21, 2020 at 11:44:41AM -0700, Florian Fainelli wrote:
> On 9/21/20 11:12 AM, Vladimir Oltean wrote:
> > On Mon, Sep 21, 2020 at 07:12:32PM +0200, Andrew Lunn wrote:
> >> On Mon, Sep 21, 2020 at 07:27:39PM +0300, Vladimir Oltean wrote:
> >>> This series exposes the SJA1105 static config as a devlink region. This
> >>> can be used for debugging, for example with the sja1105_dump user space
> >>> program that I have derived from Andrew Lunn's mv88e6xxx_dump:
> >>>
> >>> https://github.com/vladimiroltean/mv88e6xxx_dump/tree/sja1105
> >>
> >> Maybe i should rename the project dsa_dump?
> > 
> > I was unsure if you want to maintain that as a larger project.
> > 
> 
> Cannot this be part of ethtool or iproute2 at some point and we just
> have each driver author submit pretty printers for the registers?

It would be iproute2, since that is where devlink lives and where most
of the code comes from. I did take some code from ethtool which Vivien
wrote for the port registers.

The code needs refactoring anyway, i was not thinking about others
using it, and there is code in mv88e6xxx_dump which should be shared.

Vladimir, could you implement the devlink DEVLINK_CMD_INFO_GET request
so we know what sort of device is exporting the regions, and hence
which pretty printers are relevant.

   Andrew