[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200921144957.495c6f96@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date: Mon, 21 Sep 2020 14:49:57 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Stephen Hemminger <stephen@...workplumber.org>
Cc: David Ahern <dsahern@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2-next] ip: promote missed packets to the -s row
On Sat, 19 Sep 2020 09:06:58 -0700 Stephen Hemminger wrote:
> > > Does that mean "no" or "you need to be more convincing"? :)
> > >
> > > JSON output is not changed. I don't think we care about screen
> > > scrapers. If we cared about people how interpret values based
> > > on their position in the output we would break that with every
> > > release, no?
> >
> > In this case you are not adding or inserting a new column, you are
> > changing the meaning of an existing column.
> >
> > It's an 'error' stat so probably not as sensitive. I do not have a
> > strong religion on it since it seems to be making the error stat more up
> > to date.
I hope this change would encourage vendors to use the standard stats.
Because..
> Is there any way to see the old error column at all?
I had no idea how to even show error stats. I read the code multiple
times, only when I sat down to actually implement displaying did I
realize that -s -s (repeat the option) shows all the stats.
Powered by blists - more mailing lists