netdev - Re: [PATCH] net: unix: remove redundant assignment to variable 'err'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200921.145200.2255128901470643620.davem@davemloft.net>
Date:   Mon, 21 Sep 2020 14:52:00 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jingxiangfeng@...wei.com
Cc:     kuba@...nel.org, ktkhai@...tuozzo.com, pabeni@...hat.com,
        tklauser@...tanz.ch, steffen.klassert@...unet.com, cai@....pw,
        pankaj.laxminarayan.bharadiya@...el.com, arnd@...db.de,
        vcaputo@...garu.com, edumazet@...gle.com, sd@...asysnail.net,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: unix: remove redundant assignment to variable
 'err'

From: Jing Xiangfeng <jingxiangfeng@...wei.com>
Date: Mon, 21 Sep 2020 11:29:52 +0800

> After commit 37ab4fa7844a ("net: unix: allow bind to fail on mutex lock"),
> the assignment to err is redundant. So remove it.
> 
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@...wei.com>
 ...
> @@ -878,7 +878,6 @@ static int unix_autobind(struct socket *sock)
>  	if (err)
>  		return err;
>  
> -	err = 0;
>  	if (u->addr)
>  		goto out;

Yes, err is always zero here in this code path.

Applied, thanks.